After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740602 - AtkComponent.java is not making use of instance methods
AtkComponent.java is not making use of instance methods
Status: RESOLVED FIXED
Product: java-atk-wrapper
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: java-atk-wrapper maintainer(s)
java-atk-wrapper maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-23 22:51 UTC by Magdalen Berns (irc magpie)
Modified: 2015-02-27 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to address problem (1.57 KB, patch)
2014-11-23 22:53 UTC, Magdalen Berns (irc magpie)
committed Details | Review

Description Magdalen Berns (irc magpie) 2014-11-23 22:51:14 UTC
The whole way this class is set out is illogical. It creates a set of instance methods and then treats them like static methods. If we are going to use instance methods we may as well make use of their characteristics. e.g.

1. initialising private class variables which are common to more than one method.
2. instantiating them in a constructor or method with the this keyword

That way, the instantiated object can be passed about all the methods in the class. Otherwise there's not much point having instance methods and they may as well be static. In this case though I think instance methods are appropriate but they are just not getting used in an optimal way.
Comment 1 Magdalen Berns (irc magpie) 2014-11-23 22:53:51 UTC
Created attachment 291331 [details] [review]
Patch to address problem
Comment 2 André Klapper 2015-02-27 16:58:53 UTC
[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]