After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740582 - Not all shells support the += syntax
Not all shells support the += syntax
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: build
git master
Other FreeBSD
: Normal normal
: 0.3.0
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2014-11-23 16:45 UTC by Ting-Wei Lan
Modified: 2014-11-23 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Support shells which do not recognize the += syntax (804 bytes, patch)
2014-11-23 16:46 UTC, Ting-Wei Lan 		none Details | Review

Description Ting-Wei Lan 2014-11-23 16:45:22 UTC 
/bin/sh on some systems do not recognize the += syntax, so we should not use it in configure.ac.

I cannot build gegl on FreeBSD because of the use of +=:

checking whether the shell understands "+="... no
...
checking for BABL... yes
./configure: GLIB_PACKAGES+= gio-unix-2.0: not found
...
  CC       gegl-gio.lo
gegl-gio.c:26:10: fatal error: 'gio/gunixinputstream.h' file not found
#include <gio/gunixinputstream.h>
         ^
1 error generated.
Makefile:784: recipe for target 'gegl-gio.lo' failed
Comment 1 Ting-Wei Lan 2014-11-23 16:46:51 UTC 
Created attachment 291309 [details] [review]
[PATCH] Support shells which do not recognize the += syntax
Comment 2 Michael Natterer 2014-11-23 17:18:51 UTC 
Thanks, fixed in master:

commit 4717b19118eb124a2d8d53497f5e8d587b6e4cc9
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date:   Mon Nov 24 00:39:59 2014 +0800

    Bug 740582 - Not all shells support the += syntax
    
    configure: support shells which do not recognize the += syntax.

 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)