Created attachment 291219 [details] [review]
screenshot-utils: don't use spaces or colons in filenames

Screenshots are often uploaded to web services or copied to (possibly
FAT) external drives.
Don't use characters that would be incompatible with those.
See https://bugzilla.gnome.org/show_bug.cgi?id=698740

Review of attachment 291219 [details] [review]:

::: plugins/media-keys/gsd-screenshot-utils.c
@@ +302,3 @@
   /* translators: this is the name of the file that gets made up
    * with the screenshot */
+  file_name = g_strdup_printf (_("Screenshot-from-%s"), origin);

Why is space a problem?

Just to add my support in removing the colons as this blocks me from keeping the Pictures directory synched with ownCloud. The issue with colon will also materialize with Dropbox and if sharing a folder with a windows device. 

From my point of view the spaces does not cause an interoperability issue, so I'm using a patch locally that only drops the colon (as submitted on https://bugs.gentoo.org/show_bug.cgi?id=531330 ).

Created attachment 292276 [details]
Replace colon with dots

I see no reason to remove the spaces, either, and doing so is quite unaesthetic.

(In reply to comment #2)
> Review of attachment 291219 [details] [review]:
> 
> ::: plugins/media-keys/gsd-screenshot-utils.c
> @@ +302,3 @@
>    /* translators: this is the name of the file that gets made up
>     * with the screenshot */
> +  file_name = g_strdup_printf (_("Screenshot-from-%s"), origin);
> 
> Why is space a problem?

See https://bugzilla.gnome.org/show_bug.cgi?id=698740#c1 :
"Makes sense to me. While we are at this, it might be nice to turn the last
remaining space in the name into a dash too, out of respect for commandline
users who otherwise get to see ugly \-escaped spaces"

(In reply to comment #5)
> (In reply to comment #2)
> > Review of attachment 291219 [details] [review] [details]:
> > 
> > ::: plugins/media-keys/gsd-screenshot-utils.c
> > @@ +302,3 @@
> >    /* translators: this is the name of the file that gets made up
> >     * with the screenshot */
> > +  file_name = g_strdup_printf (_("Screenshot-from-%s"), origin);
> > 
> > Why is space a problem?
> 
> See https://bugzilla.gnome.org/show_bug.cgi?id=698740#c1 :
> "Makes sense to me. While we are at this, it might be nice to turn the last
> remaining space in the name into a dash too, out of respect for commandline
> users who otherwise get to see ugly \-escaped spaces"

Really not interested in that...

Bastien, I'm fine with keeping the spaces. gnome-screenshot will also have to be patched to put the spaces back in.
Any chance you can rework the patch to that effect? I might not have time to do it for a while. Thanks!

*** Bug 741490 has been marked as a duplicate of this bug. ***

Comment on attachment 292276 [details]
Replace colon with dots

That's not a patch, that's a full file.

Created attachment 295661 [details] [review]
screenshot-utils: don't use spaces or colons in filenames

--

gnome-screenshot already has been updated to use this format.

Review of attachment 295661 [details] [review]:

Looks good.

Thanks, pushed.