GNOME Bugzilla – Bug 740477
Crash when accessing a boomarked gvfs smb mount twice in a row
Last modified: 2016-06-09 11:21:02 UTC
Created attachment 291140 [details] [review] bugfix Nautilus crashes when a bookmarked smb share is accessed twice in a row (click to mount -> unmount -> click to mount again -> CRASH) This is the error: ERROR:nautilus-bookmark.c:338:nautilus_bookmark_connect_file: assertion failed: (!nautilus_file_is_gone (bookmark->details->file)) It looks like file->details->is_gone is set to TRUE after the bookmark is accessed the first time, and nautilus expects it to be FALSE during the subsequent access. Attached is a fix that resets file->details->is_gone in nautilus_file_clear_info(). Please check it before you apply, i'm not very familiar with the code and there may be a better approach. Nautilus version: 3.14.1 Arch Linux Stacktrace: Program received signal SIGABRT, Aborted. 0x00007ffff3de7967 in raise () from /usr/lib/libc.so.6 (gdb) bt
+ Trace 234357
I can confirm this bug while connecting a sftp server...
Review of attachment 291140 [details] [review]: Nice patch - looks good to me.
Pushed to master.
Hi,guys, I had tried this patch and it works for me. But I met another issue since I added this patch into nautilus and following are steps: 1.plug an USB stick 2.open the USB folder 3.unplug the USB stick result: all the desktop icon disappear. Does this issue happen only to me? Could you guys try these? Thanks
The patch committed here is causing serious regression for me: 1. Select some file 2. Press Shift+DEL to delete file 3. Confirm deletion dialog Expected result: File is deleted and cleared from view, navigating to other folder doesn't cause a crash. Actual result: File is not cleared from view after deletion, trying to navigate to other folder causes a crash. Besides, the patch is wrong according to existent nautilus logic, because the function nautilus_file_mark_gone() in nautilus_file.c is the function responsible to set 'is_gone' to TRUE, and the same function also calls nautilus_file_clear_info (file) which, by means of this patch, is reverting 'is_gone' to FALSE again. So nautilus_file_mark_gone() is setting 'is_gone' to TRUE and to FALSE again, which is obviously not the intended behaviour. I think this patch should be reverted, and then try to find the real fix for this bug.
Created attachment 293380 [details] [review] Revert commit 552ad342df7306f95bf6959af36e2b5737d36d9c Patch for revert.
Review of attachment 293380 [details] [review]: Thanks, Nelson. Let's revert the original patch.
Comment on attachment 293380 [details] [review] Revert commit 552ad342df7306f95bf6959af36e2b5737d36d9c Committed
Maybe this is related to bug 708282 which fixed a similar problem?
(In reply to comment #10) > Maybe this is related to bug 708282 which fixed a similar problem? It seems same bug as this, but the fix on 708282 was introduced in nautilus 3.13.2 and reporter of this bug was using nautilus 3.14.1 so it seems the complete bug is still unfixed. I could not reproduced this bug with a http share (webdav server). Tyang can you confirm you are getting this bug with a sftp server? and state your nautilus version? A possibility could be this bug is fixed for http shares but not for smb shares.. Uwe, before I get to install and configure a smb share, could you confirm you are still getting this bug with a recent nautilus? and state your nautilus version? in bug summary you say you're using nautilus 3.14.1 while current version on git is only 3.14.0 so maybe you confused versions?
(In reply to comment #11) > (In reply to comment #10) > > Maybe this is related to bug 708282 which fixed a similar problem? > > It seems same bug as this, but the fix on 708282 was introduced in nautilus > 3.13.2 and reporter of this bug was using nautilus 3.14.1 so it seems the > complete bug is still unfixed. > > I could not reproduced this bug with a http share (webdav server). > > Tyang can you confirm you are getting this bug with a sftp server? and state > your nautilus version? > > A possibility could be this bug is fixed for http shares but not for smb > shares.. > > Uwe, before I get to install and configure a smb share, could you confirm you > are still getting this bug with a recent nautilus? and state your nautilus > version? in bug summary you say you're using nautilus 3.14.1 while current > version on git is only 3.14.0 so maybe you confused versions? I got nautilus version 3.10.1 with the patch commited in bug#708282. I thought if this single patch can fix this bug, then there should be no problem with old version and provided patch.
Any update? I still can reproduce this issue by connecting a sftp server... Although I had version on nautilus-3.10.1 with patch provided in the bug#708282, this does not work. I had searched other commited patches with no result...
Thanks for taking the time to report this. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 693950 ***