After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740444 - create-highcontrast tool no longer works with adwaita-icon-theme
create-highcontrast tool no longer works with adwaita-icon-theme
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: HighContrast
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-20 16:48 UTC by Jakub Steiner
Modified: 2014-11-26 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update usage message for adwaita-icon-theme repo (852 bytes, patch)
2014-11-24 16:41 UTC, Michael Catanzaro 		committed Details | Review
create-highcontrast: process only symbolic icons (2.21 KB, patch)
2014-11-25 06:23 UTC, Michael Catanzaro 		accepted-commit_now Details | Review

Description Jakub Steiner 2014-11-20 16:48:56 UTC 
While we won't be needing the tool for much longer[1], it needs to be updated to work with the paths in adwaita-icon-theme module rather than gnome-icon-themes-symbolic.


[1] https://bugzilla.gnome.org/show_bug.cgi?id=732521
Comment 1 Michael Catanzaro 2014-11-24 16:40:37 UTC 
So, what's exactly wrong with this tool? As far as I can tell, it seems to work fine (you changed the icon path from gnome to Adwaita yourself several months ago), and only the usage message needs to be updated?
Comment 2 Michael Catanzaro 2014-11-24 16:41:01 UTC 
Created attachment 291378 [details] [review]
Update usage message for adwaita-icon-theme repo
Comment 3 Michael Catanzaro 2014-11-24 16:44:14 UTC 
Or, I guess you only want it run for icons that end in -symbolic, right?
Comment 4 Cosimo Cecchi 2014-11-24 20:05:03 UTC 
Review of attachment 291378 [details] [review]:

OK
Comment 5 Cosimo Cecchi 2014-11-24 20:08:27 UTC 
(In reply to comment #3)
> Or, I guess you only want it run for icons that end in -symbolic, right?

Yeah; currently the tool only checks whether the file has an SVG mime type. I believe the theme ships other SVGs that are not symbolic, so just matching the "-symbolic" suffix on the filename might be enough.
Comment 6 Michael Catanzaro 2014-11-25 06:23:10 UTC 
Created attachment 291433 [details] [review]
create-highcontrast: process only symbolic icons

Since the switch from gnome-icon-theme-symbolic to adwaita-icon-theme,
this tool has been inadvertently processing non-symbolic icons.
Comment 7 Cosimo Cecchi 2014-11-26 05:28:02 UTC 
Review of attachment 291433 [details] [review]:

Looks good, thanks.
Comment 8 Jakub Steiner 2014-11-26 13:23:49 UTC 
pushed to master