GNOME Bugzilla – Bug 740434
Allow opening a photo with other applications
Last modified: 2018-01-23 09:23:42 UTC
Photos currently has an "Open with Image Viewer" menu item (I presume that this is because Image Viewer is the default app for this mimetype). This isn't particularly useful - Photos already allows me to view the image, what I really want to do is edit it with the GIMP or similar. One possibility would be to have an "Open With..." submenu, that lists available apps.
Created attachment 316647 [details] [review] application, preview-menu: Add Open With… entry Initial implementation. We still need to decide if we want this feature only for local images or not. Also, for some reasons GIMP is launched without theme.
(In reply to Alessandro Bono from comment #1) > Initial implementation. We still need to decide if we want > this feature only for local images or not. Also, for some > reasons GIMP is launched without theme. For the time-being it is safe to assume that we will always open remote content in the browser, and use the native application only for local content. This is also what gnome-documents does, except ownCloud which it opens with the native application. The gnome-documents code has evolved a bit in this area. See the three patches tagged with https://bugzilla.gnome.org/show_bug.cgi?id=740978
Review of attachment 316647 [details] [review]: Thanks for picking this up, Alessandro. A few comments: ::: src/photos-application.c @@ +539,3 @@ + display = gtk_widget_get_display (GTK_WIDGET (parent)); + launch_context = gdk_display_get_app_launch_context (display); + g_app_info_launch_uris (info, uris, G_APP_LAUNCH_CONTEXT (launch_context), &error); Have you noticed photos_base_item_open? It would be good to have a similar machinery for this, so that we can deal with tricky edge cases where multiple items might be selected. @@ +685,3 @@ + GTK_DIALOG_DESTROY_WITH_PARENT | + GTK_DIALOG_USE_HEADER_BAR, + mime_type); The designs that I saw in Madrid used a GtkAppChooserButton in the selection toolbar, and a sub-menu in the preview hamburger menu.
Created attachment 317218 [details] [review] base-item: Don't open items without a default app
Created attachment 317219 [details] [review] base-item, local-item: Track both the default GAppInfo and it's name
These 2 patches bring the code in line with the fixes in gnome-documents.
Created attachment 322390 [details] [review] Open with in selection mode Add open with external app capability on selection mode.
Created attachment 322391 [details] [review] Open with in preview menu Improve Open with capability: - Add open with item to the preview menu. - Unify open with logic between photos-application and photos-selection-toolbar.
Created attachment 322878 [details] [review] Open with in selection mode Rebase on top of master.
Created attachment 322879 [details] [review] Open with in preview menu Rebase on top of master.
(In reply to Debarshi Ray from comment #3) > The designs that I saw in Madrid used a GtkAppChooserButton in the selection > toolbar, and a sub-menu in the preview hamburger menu. Where are those designs? I can't find them online.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/21.