After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740358 - Postbuild checks complains about 64-bit portability
Postbuild checks complains about 64-bit portability
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-11-19 12:22 UTC by Bjørn Lie
Modified: 2014-11-27 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Buildlog (66.27 KB, application/x-compressed-tar)
2014-11-19 12:26 UTC, Bjørn Lie
Details

Description Bjørn Lie 2014-11-19 12:22:41 UTC
While building gtk+ 3.15.1 for openSUSE in our buildsystem, I end up with an invaild" build (the build itself completes), since our postbuild checker complains about 64-bit portability - For someone that knows c code it                might be obvious, but not for me :-)

E: gtk3 64bit-portability-issue gtkprintbackendcups.c:2252,2253, 2305, 2309, 2311

The "above numbers" are where the checker finds the "offending" code

Aka https://git.gnome.org/browse/gtk+/tree/modules/printbackends/cups/gtkprintbackendcups.c 

Lines 2252, 2253, 2305, 2309, 2311

I see there have been a couple of commits in this area.


Also attaching buildlog, but I doubt it will be of any interest.
Comment 1 Bjørn Lie 2014-11-19 12:26:30 UTC
Created attachment 290983 [details]
Buildlog

Had to compress it as it was to big in plain txt format.
Comment 2 Matthias Clasen 2014-11-24 11:53:46 UTC
Those are places where we're using cups ipp API.
Comment 3 Marek Kašík 2014-11-27 15:28:22 UTC
It seems that I forgot to test the code against a CUPS older than 1.6:

gtkprintbackendcups.c:2252:11: warning: implicit declaration of function 'ippGetCollection'

gtkprintbackendcups.c:2253:11: warning: implicit declaration of function 'ippFirstAttribute'

gtkprintbackendcups.c:2253:11: warning: implicit declaration of function 'ippNextAttribute'

I'll fix it in master.
Comment 4 Marek Kašík 2014-11-27 16:09:47 UTC
I've fixed this in current master.
Thank you for this report.