After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740326 - Fix wrong QRECT_TO_GLMATRIX in OpenGLSurfacePainter
Fix wrong QRECT_TO_GLMATRIX in OpenGLSurfacePainter
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: qt-gstreamer
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-18 16:19 UTC by Jeremie Knuesel
Modified: 2018-05-04 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove '+1' in right and bottom dimensions of QRECT_TO_GLMATRIX (1.27 KB, patch)
2014-11-18 16:20 UTC, Jeremie Knuesel 		none Details | Review

Description Jeremie Knuesel 2014-11-18 16:19:10 UTC 
The QRECT_TO_GLMATRIX in OpenGLSurfacePainter adds 1 to the right and bottom dimensions, which was correct when using QRect rectangles but is wrong for QRectF.

This bug can go unnoticed when the QGraphicsScene uses pixel sizes, but can cause large scaling errors when using relative sizes such as a 1.333x1.0 rectangle.
Comment 1 Jeremie Knuesel 2014-11-18 16:20:06 UTC 
Created attachment 290928 [details] [review]
Remove '+1' in right and bottom dimensions of QRECT_TO_GLMATRIX
Comment 2 George Kiagiadakis 2018-05-04 11:51:58 UTC 
commit 088acb70e969f8ece8986cf2ab0c2f4ac1379f48
Author: Jeremie Knuesel <jeremie.knusel@sensefly.com>
Date:   Fri Apr 11 12:03:26 2014 +0200

    openglsurfacepainter.cpp: remove '+1' for right and bottom in QRECT_TO_GLMATRIX
    
    The '+1' calculation is wrong now that QRectF is used instead of QRect.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740326