After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740324 - test_import_machinery.TestImporter.test_invalid_repository_module_name() fails with Python 3.1 and 3.2
test_import_machinery.TestImporter.test_invalid_repository_module_name() fail...
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-18 16:08 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2016-06-07 08:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (598 bytes, patch)
2014-11-18 16:09 UTC, Arfrever Frehtes Taifersar Arahesis 		none Details | Review
Fix a test with Python 3.1/3.2 (1.31 KB, patch)
2016-06-06 18:18 UTC, Christoph Reiter (lazka) 		committed Details | Review

Description Arfrever Frehtes Taifersar Arahesis 2014-11-18 16:08:30 UTC 
test_import_machinery.TestImporter.test_invalid_repository_module_name() fails with Python 3.1 and 3.2.
This test passes with Python 2.7 and >=3.3.

======================================================================
FAIL: test_invalid_repository_module_name (test_import_machinery.TestImporter)
----------------------------------------------------------------------
Traceback (most recent call last):

+ Trace 234341

  • File "/tmp/pygobject-3.14.0tests/test_import_machinery.py", line 103 in test_invalid_repository_module_name 
    self.assertTrue('introspection typelib' in exception_string)
AssertionError: False is not true 

----------------------------------------------------------------------
Comment 1 Arfrever Frehtes Taifersar Arahesis 2014-11-18 16:09:16 UTC 
Created attachment 290926 [details] [review]
Patch
Comment 2 Simon Feltman 2014-11-19 03:44:45 UTC 
Review of attachment 290926 [details] [review]:

Looks good, can you add a commit message here as well? thanks!

https://wiki.gnome.org/GnomeLove/SubmittingPatches
https://wiki.gnome.org/Git/CommitMessages
Comment 3 Arfrever Frehtes Taifersar Arahesis 2014-11-19 06:45:58 UTC 
Commit message: "Fix Python version check in test_import_machinery.TestImporter.test_invalid_repository_module_name() to avoid failure with Python 3.1 and 3.2."
Comment 4 Christoph Reiter (lazka) 2016-06-06 18:18:49 UTC 
Created attachment 329222 [details] [review]
Fix a test with Python 3.1/3.2

Patch incorporating your commit message.

In the future please use "git format-patch" for providing patches. More info here: https://wiki.gnome.org/Newcomers/SubmittingPatches