After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740319 - QGst::Pad::sendEvent should ref() the event
QGst::Pad::sendEvent should ref() the event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: qt-gstreamer
git master
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-18 14:33 UTC by Jeremie Knuesel
Modified: 2018-01-23 23:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ref() the event before sending in Pad::sendEvent() (802 bytes, patch)
2014-11-18 14:33 UTC, Jeremie Knuesel
committed Details | Review

Description Jeremie Knuesel 2014-11-18 14:33:39 UTC
Created attachment 290913 [details] [review]
ref() the event before sending in Pad::sendEvent()

The Pad::sendEvent() method should ref() the event before sending it, as is done in Element:sendEvent().
Comment 1 Tim-Philipp Müller 2018-01-23 23:49:30 UTC
Thanks for that patch!

qt-gstreamer is unfortunately unmaintained, but I have pushed this to git master:

commit 0cf247bfb444973c5c36dde03f17c8192cb60b07 (HEAD -> master)
Author: Jeremie Knuesel <jeremie.knusel@sensefly.com>
Date:   Tue Nov 18 12:04:43 2014 +0100

    QGst::Pad: strong ref() the event in sendEvent()
    
    Just as in Element::sendEvent().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740319