After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740263 - GUPnPServiceProxy crashes in subscription_expire
GUPnPServiceProxy crashes in subscription_expire
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
unspecified
Other Linux
: Normal major
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-17 16:08 UTC by Sven Neumann
Modified: 2014-12-23 19:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the crash (1.44 KB, patch)
2014-11-17 16:10 UTC, Sven Neumann 		committed Details | Review

Description Sven Neumann 2014-11-17 16:08:11 UTC 
We have seen crashes in subscription_expire() where user_data pointed to invalid memory. I do not see an obvious way how this can have happened, but it seems like a good idea to always remove the subscription timeout when sending a new subscription request.
Comment 1 Sven Neumann 2014-11-17 16:10:26 UTC 
Created attachment 290861 [details] [review]
Patch to fix the crash

We are using this patch on our Raumfeld devices for a few weeks now and while we have always had spurious crash reports from subscription_expire(), these are all gone now. So I suggest that you accept this patch upstream.
Comment 2 Jens Georg 2014-12-23 19:05:14 UTC 
Review of attachment 290861 [details] [review]:

Done