After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740258 - Character dialogs should use a standard X button to close
Character dialogs should use a standard X button to close
Status: RESOLVED FIXED
Product: gnome-characters
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Characters maintainer(s)
GNOME Characters maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-17 15:44 UTC by Allan Day
Modified: 2014-11-24 01:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
character: Use "X" button instead of "Done" (966 bytes, patch)
2014-11-24 01:45 UTC, Daiki Ueno 		committed Details | Review

Description Allan Day 2014-11-17 15:44:28 UTC 
The character dialog windows currently have a "Done" button to close. Since you are not completing an action when you want to close the window, a standard "X" button should be used instead.

This follows the standard guidelines for dialogs:

https://developer.gnome.org/hig/stable/dialogs.html.en
Comment 1 Daiki Ueno 2014-11-24 01:45:28 UTC 
Created attachment 291332 [details] [review]
character: Use "X" button instead of "Done"
Comment 2 Daiki Ueno 2014-11-24 01:55:22 UTC 
Attachment 291332 [details] pushed as 6d4ce3c - character: Use "X" button instead of "Done"