After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740238 - mpegtsmux: Fix to use API to retrieve stream type from the elementary stream
mpegtsmux: Fix to use API to retrieve stream type from the elementary stream
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal trivial
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-17 07:01 UTC by Hyunjun Ko
Modified: 2014-11-18 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpegtsmux: Fix to use API to retrieve stream type from the elementary stream (2.11 KB, patch)
2014-11-17 07:04 UTC, Hyunjun Ko 		rejected Details | Review

Description Hyunjun Ko 2014-11-17 07:01:02 UTC 
In mpegtsmux, there needs to be replaced to use API to retrieve stream type from each elementary stream.
Comment 1 Hyunjun Ko 2014-11-17 07:04:10 UTC 
Created attachment 290834 [details] [review]
mpegtsmux: Fix to use API to retrieve stream type from the elementary stream
Comment 2 Tim-Philipp Müller 2014-11-17 09:16:27 UTC 
Why does it "need to be replaced"?
Comment 3 Hyunjun Ko 2014-11-17 09:51:47 UTC 
It's because the comments says "FIXME: Use API to retrieve this from the stream" originally.
It's not saying about this patch?
Comment 4 Olivier Crête 2014-11-17 21:10:43 UTC 
Review of attachment 290834 [details] [review]:

I'm also not sure what is gained by adding a function call? It just seems a way to make it slower.
Comment 5 Luis de Bethencourt 2014-11-18 15:14:31 UTC 
Should the FIXME be removed? Just wondering why it is there.