After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740225 - Autocorrected tag values don't show up as changed until selected
Autocorrected tag values don't show up as changed until selected
Status: RESOLVED DUPLICATE of bug 689437
Product: easytag
Classification: Other
Component: general
2.3.x
Other Linux
: Normal normal
: 2.2
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-16 22:33 UTC by J.B. Nicholson
Modified: 2014-11-16 23:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description J.B. Nicholson 2014-11-16 22:33:45 UTC
EasyTAG will attempt to automatically correct a date tag. Perhaps other autocorrections happen too but I'll focus on the date autocorrection for this bug.

The bug: EasyTAG doesn't show the autocorrected date value until the user specifically clicks on the file or uses the arrow keys to move the cursor over the file.

As a result, EasyTAG won't save the autocorrected value into the file until the file is marked as changed. Therefore autocorrected changes are unknown to the user and uncommitted to the affected files. This reduces the utility of autocorrection.

Here are the steps to illustrate the bug:

1. Prepare a directory filled with files where the date value is in the form of year-month-date (such as "1983-01-02") instead of just the year. This should get EasyTAG to try to autocorrect the date to become just the year. I used a directory of FLAC audio files for this.

2. Load that directory into EasyTAG. Immediately you see no files indicating the need to be saved. This strikes me as a bug.

3. Click on one of the files and notice that the file is now red or bold indicating that EasyTAG saw the need for a change, changed the date tag, and is telling the user that this file is now in need of saving.

I expected EasyTAG to indicate autocorrected values and any changed values immediately on directory loading so all I'd have to do is select all the files, save, and commit EasyTAG's autocorrections.
Comment 1 David King 2014-11-16 23:15:09 UTC
The date field is special, as it has a range defined by the tag type (ID3v2, Vorbis comment, MP4, and so on), whereas EasyTAG currently only handles date formatting without taking the tag type into account. The more general problem of not handling updates in the file list when updating the internal state (like when autocorrecting dates, but also when a user changes a tag field or filename and has not yet switched to another file) is handled by bug 735366.

*** This bug has been marked as a duplicate of bug 689437 ***