GNOME Bugzilla – Bug 740219
port to python3
Last modified: 2017-08-28 19:13:07 UTC
Created attachment 290810 [details] [review] python3 patch I ported gnome-tweak-tools to python3. Most probably the patch needs some refinement.
+1 Please see: https://bugzilla.redhat.com/show_bug.cgi?id=1220007
Hi, any movement on this one? As I can see, changes introduced with the patch are quite trivial. It also easy to make some conditional checks to make it work both in python2 and python3. Is there any ETA on committing this? Thanks.
(In reply to Ruslan Makhmatkhanov from comment #2) > Hi, any movement on this one? As I can see, changes introduced with the > patch are quite trivial. It also easy to make some conditional checks to > make it work both in python2 and python3. There's no value in supporting python2; this isn't a library. > Is there any ETA on committing > this? Thanks. If someone could post an updated patch (I doubt that the 1.5 year old patch is going to work properly anymore) that would be great.
Ok, I'll try to sort this out soon.
Created attachment 328645 [details] [review] Updated patch to gnome-tweak-tool Updated patch vs gnome-tweak-tool 3.20
Review of attachment 328645 [details] [review]: Looks mostly good, but can you please also drop compatibility with python2 and change the shebang? There's no reason to support both pythons; this is an app, not a library. For instance: * No use of __future__ * No testing whether imports are available
Created attachment 330637 [details] [review] Updated patch to discard 2.x compatibility
Review of attachment 330637 [details] [review]: Thanks. ::: old/gtweak/egowrapper.py @@ +90,3 @@ + pass + + # Initializing url for no reason? This function is unused. I'll remove it in a follow-up.
Oh, I see Rui has been looking after tweak-tool recently... Rui, do you want to approve this? It looks straightforward; I was about to push.
Rui says it's good to push, but I notice it doesn't work: $ jhbuild run gnome-tweak-tool Traceback (most recent call last):
+ Trace 236402
import gtweak
Any idea how I can run these tests without jhbuild?
This is my current output >>> ~/.gtt/bin/gnome-tweak-tool -t -d DEBUG : Schema not translated org.gnome.shell (domain: gnome-shell) DEBUG : Schema not translated org.gnome.shell (domain: gnome-shell) DEBUG : Schema not translated org.gnome.shell (domain: gnome-shell) DEBUG : Schema not translated org.gnome.shell (domain: gnome-shell) DEBUG : Schema not translated org.gnome.shell (domain: gnome-shell) DEBUG : Schema not translated org.gnome.shell (domain: gnome-shell) DEBUG : Schema not translated org.gnome.shell (domain: gnome-shell) DEBUG : Caching gsettings: <gtweak.gsettings._GSettingsSchema: org.gnome.shell> DEBUG : Shell version: [3, 20, 3]
(In reply to Amit Prakash Ambasta from comment #11) > Any idea how I can run these tests without jhbuild? Nope. It could be a jhbuild-specific issue. Unfortunately someone will have to dig in and figure it out for us to land this. :/
*** Bug 771910 has been marked as a duplicate of this bug. ***
Oops, we have two bugs for the same issue. I'm going to go ahead and mark this as a duplicate of the newer bug since I think the newer bug's patch is closer to being ready than this one is. *** This bug has been marked as a duplicate of bug 781321 ***