After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740176 - Remove repeated code logic
Remove repeated code logic
Status: RESOLVED FIXED
Product: java-atk-wrapper
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: java-atk-wrapper maintainer(s)
java-atk-wrapper maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-15 15:43 UTC by Magdalen Berns (irc magpie)
Modified: 2015-02-27 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to address problem (695 bytes, patch)
2014-11-15 15:46 UTC, Magdalen Berns (irc magpie)
committed Details | Review

Description Magdalen Berns (irc magpie) 2014-11-15 15:43:37 UTC
This logic is essentially repeating itself

  if (!g_thread_supported())
  {
    XInitThreads();
    g_thread_init(NULL);
  }

  if (!g_module_supported()) {
    return JNI_FALSE;
  }

It would be better to do this instead:


  if (!g_thread_supported())
  {
    XInitThreads();
    g_thread_init(NULL);
    return JNI_FALSE;
  }

Because it's nicer.
Comment 1 Magdalen Berns (irc magpie) 2014-11-15 15:46:04 UTC
Created attachment 290759 [details] [review]
Patch to address problem
Comment 2 André Klapper 2015-02-27 16:59:01 UTC
[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]