After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740133 - window-actor: Do not request unredirection when destroyed
window-actor: Do not request unredirection when destroyed
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-14 17:31 UTC by Florian Müllner
Modified: 2014-11-18 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-actor: Do not request unredirection when destroyed (1.05 KB, patch)
2014-11-14 17:31 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-11-14 17:31:00 UTC 
See patch.

This prevents a crash, as the compositor will pick the top window actor, get its MetaWindow, and set unredirection for the MetaWindowActor returned by meta_window_get_compositor_private() (which is NULL at that point).

Also see downstream bug at https://bugzilla.redhat.com/show_bug.cgi?id=1149409.
Comment 1 Florian Müllner 2014-11-14 17:31:04 UTC 
Created attachment 290725 [details] [review]
window-actor: Do not request unredirection when destroyed

WindowActors can outlive their corresponding window to animate unmap.
Unredirecting the actor does not make sense in that case, so make
sure to not request it.
Comment 2 Rui Matos 2014-11-18 13:38:21 UTC 
Review of attachment 290725 [details] [review]:

lgtm
Comment 3 Florian Müllner 2014-11-18 15:10:48 UTC 
Attachment 290725 [details] pushed as 6e25c37 - window-actor: Do not request unredirection when destroyed