After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740131 - [PATCH] wifi: don't query nl80211 for non-WiFi devices
[PATCH] wifi: don't query nl80211 for non-WiFi devices
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Wi-Fi
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-1.0
 
 
Reported: 2014-11-14 17:08 UTC by Dan Williams
Modified: 2014-12-01 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-wifi-don-t-query-nl80211-for-non-WiFi-devices.patch (5.02 KB, patch)
2014-11-14 17:08 UTC, Dan Williams
accepted-commit_now Details | Review

Description Dan Williams 2014-11-14 17:08:50 UTC
Created attachment 290724 [details] [review]
0001-wifi-don-t-query-nl80211-for-non-WiFi-devices.patch

The upstream kernel added module aliases for nl80211 in commit
fb4e156886ce6e8309e912d8b370d192330d19d3, so querying nl80211
now auto-loads the module.  Previously NM was doing this to
determine whether an 'ethernet-like' device was a Wi-Fi device
that supported nl80211, but this leads to the nl80211 loading
on platforms that will never have or use Wi-Fi.

Since every nl80211-capable device will already have
DEVTYPE=wlan set (from /sys/class/net/wlan0/uevent), we can use
that as an indicator that the 'ethernet-link' device is WiFi
instead of asking nl80211.
Comment 1 Dan Winship 2014-11-15 13:58:37 UTC
Comment on attachment 290724 [details] [review]
0001-wifi-don-t-query-nl80211-for-non-WiFi-devices.patch

ok
Comment 2 Dan Williams 2014-11-17 15:46:20 UTC
Pushed after fixing up the commit message (link -> like)