GNOME Bugzilla – Bug 740124
mpegtsmux: set group-id in stream-start event
Last modified: 2018-11-03 13:28:42 UTC
Currently, mpegts muxer create a new STREAM_START event and push it downstream without setting group_id causing a basesink derived element to output following FIXME message: 0:00:00.044971265 7168 0x92d8a60 FIXME basesink gstbasesink.c:3064:gst_base_sink_default_event:<fakesink0> stream-start event without group-id. Consider implementing group-id handling in the upstream elements I propose to set a new group_id using helper before sending stream-start event. This FIXME will also happen with others muxer, I can fix them if the solution is correct.
Created attachment 290720 [details] [review] mpegtsmux: set group-id in stream-start event
Any thought about this ?
Review of attachment 290720 [details] [review]: ::: gst/mpegtsmux/mpegtsmux.c @@ +1680,3 @@ + stream_start = gst_event_new_stream_start (s_id); + gst_event_set_group_id (stream_start, gst_util_group_id_next ()); + gst_pad_push_event (mux->srcpad, stream_start); Isn't the purpose of group-id to have streams that are to be played together have the same group-id? Check https://developer.gnome.org/gstreamer/stable/gstreamer-GstEvent.html#gst-event-set-group-id
(In reply to Thiago Sousa Santos from comment #3) > Review of attachment 290720 [details] [review] [review]: > > ::: gst/mpegtsmux/mpegtsmux.c > @@ +1680,3 @@ > + stream_start = gst_event_new_stream_start (s_id); > + gst_event_set_group_id (stream_start, gst_util_group_id_next ()); > + gst_pad_push_event (mux->srcpad, stream_start); > > Isn't the purpose of group-id to have streams that are to be played together > have the same group-id? Yes. Currently, I don't clearly understand your remark, so correct me if I'm wrong: it is a muxer which have only one src pad, hence it create only one output stream and one stream_start event is pushed downstream. There is no multiple stream in this case so no need to store and reuse the group id if it's what you meant.
(In reply to Aurélien Zanelli from comment #4) > (In reply to Thiago Sousa Santos from comment #3) > > Review of attachment 290720 [details] [review] [review] [review]: > > > > ::: gst/mpegtsmux/mpegtsmux.c > > @@ +1680,3 @@ > > + stream_start = gst_event_new_stream_start (s_id); > > + gst_event_set_group_id (stream_start, gst_util_group_id_next ()); > > + gst_pad_push_event (mux->srcpad, stream_start); > > > > Isn't the purpose of group-id to have streams that are to be played together > > have the same group-id? > Yes. > > Currently, I don't clearly understand your remark, so correct me if I'm > wrong: > it is a muxer which have only one src pad, hence it create only one output > stream and one stream_start event is pushed downstream. There is no multiple > stream in this case so no need to store and reuse the group id if it's what > you meant. Sorry. I thought you were talking about the demuxer. I don't see an use case where that would be relevant for muxers other than just silencing the FIXME.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/191.