GNOME Bugzilla – Bug 740084
Install missing libtool files and versioned shared libraries for a bunch of recipes
Last modified: 2014-11-26 18:41:57 UTC
The following recipes are missing versioned libraries/libtool (.la) files: libsrtp, openssl, openh264 (versioned missing). The attached patches fix these issues.
Created attachment 290662 [details] [review] openssl.recipe: Fix libdir, install libtool file, etc
Created attachment 290663 [details] [review] libsrtp.recipe: Install a libtool file as well
Created attachment 290664 [details] [review] openh264.recipe: Install a versioned shared lib, and a libtool file
Review of attachment 290664 [details] [review]: ::: recipes/openh264/versioned-shared-library.patch @@ +20,3 @@ ++ifneq ($(filter $(OS),android linux ios darwin freebsd),) ++SHAREDLIBVERSION=.0 ++SHAREDLIBSUFFIXVER=$(SHAREDLIBSUFFIX)$(SHAREDLIBVERSION) I don't think this is correct for ios and darwin. There you usually have libfoo.X.dylib instead of libfoo.so.X, e.g. libgstreamer-1.0.0.dylib instead of libgstreamer-1.0.dylib.0. Additionally like on other systems you also have a libfoo.dylib without the version.
(In reply to comment #2) > Created an attachment (id=290663) [details] [review] > libsrtp.recipe: Install a libtool file as well For some reason this seems to break the windows buildslave: https://ci.gstreamer.net/job/cerbero-cross-mingw32/1160/console > i686-w64-mingw32-gcc: error: /home/jenkins/workspace/cerbero-cross-mingw32 /workdir/dist/windows_x86/lib/libsrtp.dll.a: No such file or directory Something wrong in the .la file?
Created attachment 291096 [details] [review] Fix build on Windows and fix library path on OS X (In reply to comment #5) > (In reply to comment #2) > > Created an attachment (id=290663) [details] [review] [details] [review] > > libsrtp.recipe: Install a libtool file as well > > For some reason this seems to break the windows buildslave: > https://ci.gstreamer.net/job/cerbero-cross-mingw32/1160/console > > > i686-w64-mingw32-gcc: error: /home/jenkins/workspace/cerbero-cross-mingw32 /workdir/dist/windows_x86/lib/libsrtp.dll.a: No such file or directory > > Something wrong in the .la file? The attached patch should fix that. (In reply to comment #4) > Review of attachment 290664 [details] [review]: > > ::: recipes/openh264/versioned-shared-library.patch > @@ +20,3 @@ > ++ifneq ($(filter $(OS),android linux ios darwin freebsd),) > ++SHAREDLIBVERSION=.0 > ++SHAREDLIBSUFFIXVER=$(SHAREDLIBSUFFIX)$(SHAREDLIBVERSION) > > I don't think this is correct for ios and darwin. There you usually have > libfoo.X.dylib instead of libfoo.so.X, e.g. libgstreamer-1.0.0.dylib instead of > libgstreamer-1.0.dylib.0. Additionally like on other systems you also have a > libfoo.dylib without the version. You're absolutely right, I'll fix that patch. Additionally, libsrtp had the same problem, and I've fixed that with this patch as well.
Created attachment 291169 [details] [review] openh264: Fix build on Windows and fix library path on OS X This patch and the one above should fix the gst-plugins-bad-1.0 build on Windows.
Created attachment 291170 [details] [review] openh264.recipe: Install a versioned shared lib, and a libtool file Rebased patch that replaces attachment 290664 [details] [review]; just this and the patch in comment 6 are necessary.
You might want to provide those patches also to the libsrtp and openh264 community ;)
(In reply to comment #9) > You might want to provide those patches also to the libsrtp and openh264 > community ;) libsrtp: https://github.com/cisco/libsrtp/pull/86 openh264: https://github.com/cisco/openh264/pull/1565