After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740044 - The ATK_STATE_ACTIVE docs can be interpreted as only applying to windows
The ATK_STATE_ACTIVE docs can be interpreted as only applying to windows
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: docs
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-13 03:10 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-11-13 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.93 KB, patch)
2014-11-13 03:10 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2014-11-13 03:10:29 UTC 
Created attachment 290571 [details] [review]
Proposed patch

The current documentation for ATK_STATE_ACTIVE is: "Indicates a window is currently the active window, or is an active subelement within a container or table".

While presumably a window cannot be "an active subelement within a container or table," the documentation might cause implementors to not use ATK_STATE_ACTIVE for non-windows. The documentation should probably also distinguish "active" from "focused" and "selected" so that they don't use ATK_STATE_ACTIVE when what they mean is ATK_STATE_FOCUSED or ATK_STATE_SELECTED.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-11-13 12:10:03 UTC 
Review of attachment 290571 [details] [review]:

lgtm. thanks.
Comment 2 Joanmarie Diggs (IRC: joanie) 2014-11-13 12:15:34 UTC 
Comment on attachment 290571 [details] [review]
Proposed patch

Thanks!

https://git.gnome.org/browse/atk/commit/?id=cb699320