GNOME Bugzilla – Bug 740024
rtspconnection: Need to implement to get current queued messages and amount of bytes
Last modified: 2018-11-03 11:32:32 UTC
Currently, rtspconnection supports to get maximum bytes and the number of messages in the queue by the function gst_rtsp_watch_get_send_backlog. But it's not supporred to get current status of the queue. I think it's needed by user, especially, who needs to know the current status like amount of bytes queued. If users get it, user could control flow data manually by adjusting bitrate or something like that. If a function gst_rtsp_watch_get_current_backlog is implemented, it would be good. What do you think about this?
Also see bug #738990
Oh. There was exactly same issue in gst-rtsp-server. I think if this function is supported, gst-rtsp-server could use this function to provide current information to user.
Created attachment 290527 [details] [review] rtspconnection: Get current queued messages and amount of bytes
Hyunjun's patch looks good to me. Follows the same style as the function gst_rtsp_watch_get_send_backlog() above. My +1 but will wait for further review.
Comment on attachment 290527 [details] [review] rtspconnection: Get current queued messages and amount of bytes Hyunjun: Thanks for your patch. It seems correct but I'm not the one making a final decision on it. While you wait for someone else's review please fix the following: Add the bug # to your patch commit message. You can look for an example on how to do it from some other patches here on bugzilla. Add a "Since:" API marking to your function documentation, I consulted internally and this one will likely be in for 1.6 so feel free to go with that version. There are some associated documentation changes missing, run make check-exports with your patch applied for a hint. Please submit a new patch after these minor fixes. Thanks a lot.
Thanks for guide in detail. I'm going to work on it.
Created attachment 291361 [details] [review] Minor fixes update
Created attachment 302436 [details] [review] rtspconnection: get current queued messages and amount of bytes Rebased on git master It's needed to get current status, such like the issue https://bugzilla.gnome.org/show_bug.cgi?id=738990
Created attachment 302438 [details] [review] rtspconnection: get current queued messages and amount of bytes Sorry. Rebased.
*** Bug 738990 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/142.