After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740003 - pad: fail drop queries
pad: fail drop queries
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-12 11:48 UTC by Vincent Penquerc'h
Modified: 2014-11-12 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
drop failed queries (1.46 KB, patch)
2014-11-12 11:48 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2014-11-12 11:48:31 UTC 
Created attachment 290501 [details] [review]
drop failed queries

Previously, dropping a query from a pad probe would deem the
query succeeded, and the caller might then assume the query's
results are valid, and thus dereference an invalid object
such as a GstCaps.

We now assume dropped queries did not succeed. Dropped events
and buffers are still deemed a success.

This patch might break expectations from some client code (ie, failure causing something upstream to stop the pipeline) ?
Comment 1 Vincent Penquerc'h 2014-11-12 14:07:02 UTC 
commit d4c551a29250723c44a5de8283c46db63b1932f5
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Nov 3 17:46:57 2014 +0000

    pad: fail dropped queries
    
    Previously, dropping a query from a pad probe would deem the
    query succeeded, and the caller might then assume the query's
    results are valid, and thus dereference an invalid object
    such as a GstCaps.
    
    We now assume dropped queries did not succeed. Dropped events
    and buffers are still deemed a success.
    
    Added back after previous revert, as it's been double checked.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740003