After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739958 - [review] nmcli: show gateway as a separate item in active connection data
[review] nmcli: show gateway as a separate item in active connection data
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmcli
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-11 11:21 UTC by Jiri Klimes
Modified: 2014-11-11 16:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jiri Klimes 2014-11-11 11:21:00 UTC 
Gateway is a separate item in IP configuration. So move it out of addresses in active connection data.

Example:
$ nmcli -f active con show my-active-eth0

Branch: jk/nmcli-gateway
Comment 1 Dan Winship 2014-11-11 14:26:27 UTC 
When printing non-active connections, we print ADDRESSES, GATEWAY, ROUTES, while for active connections, you did it as ADDRESSES, ROUTES, GATEWAY. We should be consistent.

Also, the code is still setting "gw" as part of filling in addr_arr, even though it logically doesn't belong there any more.
Comment 2 Jiri Klimes 2014-11-11 15:08:51 UTC 
Fixed and re-pushed.
Comment 3 Thomas Haller 2014-11-11 15:53:13 UTC 
LGTM
Comment 4 Jiri Klimes 2014-11-11 16:32:39 UTC 
142dbf2 cli: show gateway as a separate item in active connection data (bgo #739958)