After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739942 - extract: Allow empty artist in media_art_set
extract: Allow empty artist in media_art_set
Status: RESOLVED FIXED
Product: libmediaart
Classification: Other
Component: Extraction
unspecified
Other All
: Normal normal
: ---
Assigned To: libmediaart maintainer(s)
libmediaart maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-11 08:10 UTC by Jens Georg
Modified: 2015-05-15 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
extract: Allow empty artist in media_art_set (777 bytes, patch)
2014-11-11 08:10 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2014-11-11 08:10:31 UTC 
The function handles a NULL artist just fine. The current behavior also
breaks the (allow-none) annotation of artist in Process.buffer.
Comment 1 Jens Georg 2014-11-11 08:10:33 UTC 
Created attachment 290401 [details] [review]
extract: Allow empty artist in media_art_set
Comment 2 Martyn Russell 2014-11-11 09:30:23 UTC 
Comment on attachment 290401 [details] [review]
extract: Allow empty artist in media_art_set

Looks right to me, one thing I really don't understand about the older code is why we compare to " " for the artist in the first place (and not an empty string)... probably should fix that but I would need to check there isn't some thing in the spec about this first.
Comment 3 Jens Georg 2014-11-11 10:54:27 UTC 
Empty is represented by md5(" ") according to the spec, so I suspect it's covering passing this.
Comment 4 Jens Georg 2015-05-15 18:53:27 UTC 
Attachment 290401 [details] pushed as 8281496 - extract: Allow empty artist in media_art_set