After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739940 - Fix build of GDI+ Loaders
Fix build of GDI+ Loaders
Status: RESOLVED DUPLICATE of bug 739441
Product: gdk-pixbuf
Classification: Platform
Component: GDI loader
git master
Other Windows
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-11 06:17 UTC by Fan, Chun-wei
Modified: 2017-02-17 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix build of GDI+ loaders (831 bytes, patch)
2014-11-11 06:20 UTC, Fan, Chun-wei
none Details | Review

Description Fan, Chun-wei 2014-11-11 06:17:02 UTC
Hi,

In commit f37f850, gdk-pixbuf-i18n.h was removed, plus the descriptions used the NC_ macro (which was not in gdk-pixbuf-i18n.h to start with), so one is not able to build the GDI+ loaders.  I will attach a patch to fix its build, for people who are still interested to use it (though they are definitely not in a great shape and perhaps we should eventually replace this code with WIC[1], which would be in another bug when it materializes, especially if it would cope better than GDI+ as GDI+'s successor).

[1]: http://msdn.microsoft.com/zh-tw/library/windows/desktop/ee719902%28v=vs.85%29.aspx
Comment 1 Fan, Chun-wei 2014-11-11 06:20:16 UTC
Created attachment 290395 [details] [review]
Fix build of GDI+ loaders

Hi,

This is my fix for this issue.

With blessings, thank you!
Comment 2 Tobias Mueller 2017-02-17 09:44:41 UTC
I think 852234fb53ecef5aa0d86b581e1d505eb82c5ceb from https://bugzilla.gnome.org/show_bug.cgi?id=739441 fixed this. Please reopen if not.

*** This bug has been marked as a duplicate of bug 739441 ***