GNOME Bugzilla – Bug 739929
Build webkitgtk+ >= 2.6.0
Last modified: 2014-11-28 18:24:56 UTC
The 2.4.x releases were the last ones to have the WK1 API, so to accommodate those who have not ported to WK2, the newer releases were made parallel installable. However, this means that the pkgconfig file provided by the newer releases has been renamed to webkit2gtk-4.0.pc. So, either we need to have the newer webkitgtk+ in Continuous, or WK2 applications need to retain compatibility with older releases. It is easier to do the former, because doing the latter is non-trivial for epiphany. As more complex applications join the WK2 party (eg., evolution, geary, yelp) it is only going to become harder.
Created attachment 290408 [details] [review] manifest: Add webkitgtk-2.6.2 to the build
Created attachment 290409 [details] [review] Revert "manifest.json: Fix build"
Created attachment 290410 [details] [review] Revert "manifest: tag epiphany"
Review of attachment 290408 [details] [review]: ::: manifest.json @@ +760,3 @@ "--disable-maintainer-mode"]}, + {"src": "tarball:http://www.webkitgtk.org/releases/webkitgtk-2.6.2.tar.xz", It's not that simple as this release switched to cmake. Look at libssh-cmake-buildapi.patch. We'd need to do something similar except also plumb through -DPORT=GTK. (Or teach continuous how to deal with cmake more directly internally)
Created attachment 291147 [details] [review] manifest: Add webkitgtk-2.6.4 to the build
Created attachment 291152 [details] [review] manifest: define empty enchant lib dirs Tried Debarshi's patch and it seem to need some more changes
Created attachment 291153 [details] [review] manifest: add config opts for webkit2
Created attachment 291156 [details] [review] manifest: build enchant before webkitgtk4 We should build enchant before webkitgtk4
Review of attachment 291153 [details] [review]: ::: manifest.json @@ +765,3 @@ + "patches": ["webkitgtk-cmake-buildapi.patch"], + "config-opts": ["--enable-introspection", + "--enable-debug-symbols=min"]}, Are you sure that a --enable-introspection flag in the new cmake build setup? I grepped through the Git sources and the Fedora spec and could not see one.
Created attachment 291188 [details] [review] manifest: build enchant before webkitgtk4
Created attachment 291189 [details] [review] manifest: specify linker bugs for webkitgtk4 We don't really need config-ops for it. Locally the build fails for me, so lets try linker flags from Fedora spec file
Please push if it works locally.
Pushed a reworked patch (CMake requires a separate env for cflags): https://git.gnome.org/browse/gnome-continuous/commit/?id=9c0b515496f0bc4faac34fd42b99ea51d44a7069
WebkitGTK breaks builddisks now, reopening the bug. I'll try to build it locally without debug symbols
Random thought: is this caused by having 2 webkitgtk+ builds?
Might be "fixed" by https://git.gnome.org/browse/gnome-continuous/commit/?id=07fa0166fac6b18b7308a675c7f54876bb67a186 I know at least Fedora's GPG signing chokes on webkitgtk debuginfo. (A minute passes while Colin logs into build gnome.org...) Oh yeah, look at this: ostree@spinner:~/ostbuild/work$ ostree --repo=repo ls -R gnome-continuous/components/webkitgtk4/x86_64 /debug d02775 0 0 0 /debug d02775 0 0 0 /debug/usr d02775 0 0 0 /debug/usr/lib d02775 0 0 0 /debug/usr/lib/debug d02775 0 0 0 /debug/usr/lib/debug/.build-id d02775 0 0 0 /debug/usr/lib/debug/.build-id/1d -00775 0 0 25407 /debug/usr/lib/debug/.build-id/1d/1a005569b6c7a62a742450aad8f2cec6a20f67.debug d02775 0 0 0 /debug/usr/lib/debug/.build-id/1f -00775 0 0 99480 /debug/usr/lib/debug/.build-id/1f/ac5b89e44d581457916f0cb1f794785c54d250.debug d02775 0 0 0 /debug/usr/lib/debug/.build-id/29 -00775 0 0 25621 /debug/usr/lib/debug/.build-id/29/0ee42614e3ea02ecbceb6d4997117fe0fd38e3.debug d02775 0 0 0 /debug/usr/lib/debug/.build-id/45 -00775 0 0 2057770851 /debug/usr/lib/debug/.build-id/45/fe3b97ccbe6e6348de5183202c001809ac260e.debug d02775 0 0 0 /debug/usr/lib/debug/.build-id/95 -00775 0 0 25661 /debug/usr/lib/debug/.build-id/95/311ca56401b5ffe81e81f98f5e6c9f231a5807.debug d02775 0 0 0 /debug/usr/lib/debug/.build-id/be -00775 0 0 476690850 /debug/usr/lib/debug/.build-id/be/7d93c1b0b41f0c7c1d95195055ac3f9c2604ae.debug -00775 0 0 1797070549 /debug/usr/lib/debug/.build-id/be/81bc714b5369e7ab2554a9462d695d63e512e5.debug d02775 0 0 0 /debug/usr/lib/debug/.build-id/df -00775 0 0 4069961 /debug/usr/lib/debug/.build-id/df/fec18cccb72ce1f5e129c87ee92e32faf91efa.debug $ gjs -c 'print(imports.gi.GLib.format_size(1797070549 + 2057770851 + 4069961 + 476690850))' 4.3 GB $ So...I think we may need to hack Continuous to not generate debuginfo for webkitgtk.
(In reply to comment #16) > So...I think we may need to hack Continuous to not generate debuginfo for > webkitgtk. Pushed https://git.gnome.org/browse/gnome-continuous/commit/?id=eeaf10a4956e4ad7fe08193a601e2e0db78242f4, this should solve it
WK2 now available since http://build.gnome.org/#/build/20141128.35