After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739873 - extract: Don't print confusing random strerror
extract: Don't print confusing random strerror
Status: RESOLVED FIXED
Product: libmediaart
Classification: Other
Component: Extraction
unspecified
Other All
: Normal normal
: ---
Assigned To: libmediaart maintainer(s)
libmediaart maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-10 12:30 UTC by Jens Georg
Modified: 2015-05-31 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
extract: Don't print confusing random strerror (1.25 KB, patch)
2014-11-10 12:30 UTC, Jens Georg
committed Details | Review

Description Jens Georg 2014-11-10 12:30:40 UTC
Minor improvement on logging. The other symlinks already have that change,
only those two were missing.
Comment 1 Jens Georg 2014-11-10 12:30:43 UTC
Created attachment 290336 [details] [review]
extract: Don't print confusing random strerror

debug was printing g_strerror(errno) even in success case, leaving
weird confusing messages, indicating an error even if symlinking succeeded.
Comment 2 Martyn Russell 2014-11-11 09:52:35 UTC
Comment on attachment 290336 [details] [review]
extract: Don't print confusing random strerror

Looks good to me! :)
Comment 3 Jens Georg 2015-05-15 18:53:17 UTC
Attachment 290336 [details] pushed as 1f6a4d9 - extract: Don't print confusing random strerror
Comment 4 Martyn Russell 2015-05-31 13:03:27 UTC
Nice patch Jens!