GNOME Bugzilla – Bug 739837
Allow label overwrite in keyboard layout
Last modified: 2014-11-12 08:57:52 UTC
Created attachment 290264 [details] [review] Allow label overwrite Currently some buttons do only have its name as label. This is not always useful. I.e. for the dead-keys the label is often only "dead". In some keyboard layout it is preferred to have a symbol as label. This allows to overwrite the default label in the keyboard layout.
I'm not good at English, but perhaps "override" might be more appropriate than "overwrite"? By the way, I'm a bit concerned about adding optional arguments to the KeyModel constructor this way, because the optional argument affects the C library ABI: CaribouKeyModel* caribou_key_model_new (const gchar* name, const gchar* text, const gchar *label_overwrite); Perhaps KeyModel:label could be a writable property, so this code: KeyModel key = new KeyModel (name, text, label_overwrite); can be written as: KeyModel key = new KeyModel (name, text); if (label_overwrite != null) key.label = label_overwrite; Thoughts?
Created attachment 290420 [details] [review] Allow label override You are right, it should be "override". I like your idea. It makes the override more obvious. The only disadvantage I see, is that the label needs to be publicly settable for this to work.
Review of attachment 290420 [details] [review]: Thanks. I think it's okay to make the setter public, rather it might be useful for applications that want to change labels at run time.