After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739820 - Superflous frame in the history dialog
Superflous frame in the history dialog
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-08 15:06 UTC by Lapo Calamandrei
Modified: 2014-11-10 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the current history dialog (30.40 KB, image/png)
2014-11-08 15:06 UTC, Lapo Calamandrei 		  Details
Trivial patch to remove the frame and margins (1.59 KB, patch)
2014-11-08 15:06 UTC, Lapo Calamandrei 		accepted-commit_now Details | Review
Screenshot of the history dialog with the patch applied (29.69 KB, image/png)
2014-11-08 15:07 UTC, Lapo Calamandrei 		  Details

Description Lapo Calamandrei 2014-11-08 15:06:03 UTC 
Created attachment 290219 [details]
Screenshot of the current history dialog

The frame in the history dialog is not needed and just adds visual noise
Comment 1 Lapo Calamandrei 2014-11-08 15:06:56 UTC 
Created attachment 290220 [details] [review]
Trivial patch to remove the frame and margins

See the screenshots
Comment 2 Lapo Calamandrei 2014-11-08 15:07:40 UTC 
Created attachment 290221 [details]
Screenshot of the history dialog with the patch applied
Comment 3 Rui Matos 2014-11-08 15:41:29 UTC 
Review of attachment 290220 [details] [review]:

looks better indeed
Comment 4 Lapo Calamandrei 2014-11-10 19:10:21 UTC 
Pushed to master