After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739818 - Superflous frame in the keyboard panel
Superflous frame in the keyboard panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
git master
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-08 14:41 UTC by Lapo Calamandrei
Modified: 2014-11-10 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the current keyboard panel (28.29 KB, image/png)
2014-11-08 14:41 UTC, Lapo Calamandrei
  Details
Screenshot of the keyboard panel with the patch applied (27.57 KB, image/png)
2014-11-08 14:42 UTC, Lapo Calamandrei
  Details
Trivial patch to remove the frame and margins (1.18 KB, patch)
2014-11-08 14:43 UTC, Lapo Calamandrei
accepted-commit_now Details | Review

Description Lapo Calamandrei 2014-11-08 14:41:55 UTC
Created attachment 290216 [details]
Screenshot of the current keyboard panel

The frame is not needed in the keyboard panel just adds visual noise.
Comment 1 Lapo Calamandrei 2014-11-08 14:42:44 UTC
Created attachment 290217 [details]
Screenshot of the keyboard panel with the patch applied
Comment 2 Lapo Calamandrei 2014-11-08 14:43:56 UTC
Created attachment 290218 [details] [review]
Trivial patch to remove the frame and margins

See the screenshots
Comment 3 Rui Matos 2014-11-08 15:43:01 UTC
Review of attachment 290218 [details] [review]:

++
Comment 4 Lapo Calamandrei 2014-11-10 19:10:31 UTC
Pushed to master