After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739789 - v4l2allocator: fix error message if allocator is already active
v4l2allocator: fix error message if allocator is already active
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal trivial
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-07 15:16 UTC by Aurélien Zanelli
Modified: 2014-11-07 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
v4l2allocator: fix error message if allocator is already active (838 bytes, patch)
2014-11-07 15:17 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2014-11-07 15:16:12 UTC
Message if allocator is already active is currently wrong in allocator_start(), we have not request any buffer from drivers.
Comment 1 Aurélien Zanelli 2014-11-07 15:17:38 UTC
Created attachment 290177 [details] [review]
v4l2allocator: fix error message if allocator is already active
Comment 2 Nicolas Dufresne (ndufresne) 2014-11-07 15:40:23 UTC
Review of attachment 290177 [details] [review]:

Oops, copy paste error clearly, thanks for spotting.
Comment 3 Nicolas Dufresne (ndufresne) 2014-11-07 15:43:45 UTC
Comment on attachment 290177 [details] [review]
v4l2allocator: fix error message if allocator is already active

commit 36532f507094361a42d24da79cdcbf6ab3b965e0
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Fri Nov 7 16:11:24 2014 +0100

    v4l2allocator: fix error message if allocator is already active
    
    https://bugzilla.gnome.org/show_bug.cgi?id=73978
Comment 4 Nicolas Dufresne (ndufresne) 2014-11-07 15:45:02 UTC
And for 1.4.5
commit 3b8ad44804dc269bfd26b84e7707f7efeb5b2e44
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Fri Nov 7 16:11:24 2014 +0100

    v4l2allocator: fix error message if allocator is already active
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739789