GNOME Bugzilla – Bug 739784
Layout improvements
Last modified: 2021-06-09 16:24:43 UTC
Created attachment 290172 [details] modified screenshot The layout of the background grid could do with some improvements. Specifically: * The padding around the icon grid is unnecessary, and introduces superfluous noise. * You can only fully see three thumbnails. It would be good to expose a bit more content, and give a stronger hint that there are more images below. * It would be nice to give the thumbnails a shadow. I've attached a screenshot, alongside a modified version which illustrates the proposed changes.
We could also make the thumbnails in the colours section smaller, since you don't need to see the detail of those, and it would let you see more colours at once.
(In reply to comment #0) > * The padding around the icon grid is unnecessary, and introduces superfluous > noise. Lapo took care of it in bug 739821
I think the main thing here is to increase the height of the background chooser dialog a bit. Looking at it in the inspector, the height is currently set to 520. Changing it to 600 would be about right. I'd do it myself, but I can't find where to change the value...
Created attachment 291384 [details] [review] background: Increase the height of the chooser dialog
Review of attachment 291384 [details] [review]: > ... and take this opportunity to simplify the height calculation logic. Simplify and change? This needs to be done separately, certainly. And 600 height doesn't fit on a 800x600 screen when you add a top panel.
(In reply to Bastien Nocera from comment #5) > ... And 600 > height doesn't fit on a 800x600 screen when you add a top panel. Can't the window compensate for this? (Request 600 height, but go lower if there isn't room.)
Created attachment 300343 [details] screenshot Attached is a screenshot of the dialog in 3.15.92. Now that we have overlaid scrollbars, you can see that the padding on the left and right is uneven. Would it be possible to remove 15px from the width? This would ensure even padding on each side.
(In reply to Allan Day from comment #7) > Created attachment 300343 [details] > Would it be possible to remove 15px from the width? This would ensure even > padding on each side. I have been planning to port it to GtkFlowBox for a while. Now is the time to do it.
Created attachment 359392 [details] [review] Removed some minor deprecated properties and cleanups.
Review of attachment 359392 [details] [review]: Hi Miguel, thanks for your patch and sorry for the delay. Since we're on the verge of landing the redesigned Backgrounds panel, I'll mark this patch as reviewed and let it stay here for the time being. We'll revisit this ticket after the redesign lands.
(In reply to Georges Basile Stavracas Neto from comment #10) > Review of attachment 359392 [details] [review] [review]: > > Hi Miguel, thanks for your patch and sorry for the delay. > > Since we're on the verge of landing the redesigned Backgrounds panel, I'll > mark this patch as reviewed and let it stay here for the time being. We'll > revisit this ticket after the redesign lands. Nevermind, I aware your workload, awesome work indeed.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.