After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739777 - Subtitles do not clear properly
Subtitles do not clear properly
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
0.5.10
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 731852
 
 
Reported: 2014-11-07 12:38 UTC by Simon Farnsworth
Modified: 2015-01-27 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Fix clearing of subtitle overlay (1.44 KB, patch)
2014-11-07 12:38 UTC, Simon Farnsworth 		accepted-commit_now Details | Review

Description Simon Farnsworth 2014-11-07 12:38:34 UTC 
When there's a long gap between DVB subtitles, the old overlay gets stuck on screen. Attached patch fixes it.
Comment 1 Simon Farnsworth 2014-11-07 12:38:51 UTC 
Created attachment 290156 [details] [review]
[PATCH] Fix clearing of subtitle overlay


dvbsuboverlay signals no subtitles present by not setting
GstVideoOverlayCompositionMeta on a buffer.

Detect this, and remove subtitles whenever we have no overlay composition to
hand.

Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
---
 gst/vaapi/gstvaapipluginutil.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
Comment 2 Gwenole Beauchesne 2014-11-26 14:27:14 UTC 
Review of attachment 290156 [details] [review]:

LGTM.
Comment 3 sreerenj 2015-01-27 14:31:29 UTC 
Pushed, Thanks for the patch.
commit bee7460f3541f5eb3f6511ca8d74c3ce6533bf62
Author: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Date:   Tue Jan 27 16:25:21 2015 +0200

    pluginutil: Fix clearing of subtitle overlay
    
    dvbsuboverlay signals no subtitles present by not setting
    GstVideoOverlayCompositionMeta on a buffer.
    
    Detect this, and remove subtitles whenever we have no overlay composition to
    hand.
    
    Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>