After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739774 - Sidebar styling
Sidebar styling
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 732050
Blocks:
 
 
Reported: 2014-11-07 11:57 UTC by Allan Day
Modified: 2015-09-04 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
widget factory screenshot (8.09 KB, image/png)
2014-11-07 11:57 UTC, Allan Day
  Details
Adwaita: make sidebar close to the mockups (4.73 KB, patch)
2014-11-07 12:51 UTC, Jakub Steiner
none Details | Review

Description Allan Day 2014-11-07 11:57:25 UTC
Created attachment 290154 [details]
widget factory screenshot

GTK+ has a new sidebar widget (a screenshot from the widget factory is attached). The current styling doesn't match what we are using in the mockups. An example:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/nautilus/nautilus-next/recent-grid.png

Features of this:

 * Grey background.
 * First row is separated from the top of the sidebar by a small amount of padding. This ensures that it doesn't bleed into widgets that are above, particularly when it is selected.
 * No separators between rows.
 * The sidebar has a border separating it from the other pane.

Or maybe the mockups are wrong...
Comment 1 Jakub Steiner 2014-11-07 12:51:46 UTC
Created attachment 290157 [details] [review]
Adwaita: make sidebar close to the mockups

- FIXME: .list-row separators, border not working.
Comment 2 Jakub Steiner 2014-11-07 12:52:48 UTC
More of a TODO than a useful patch. Not quite sure how to get rid of the separators in the ListBox, nor is the .list border working...
Comment 3 Lapo Calamandrei 2014-11-07 18:14:03 UTC
Last time I checked it was possible to add borders to the list elements only, we need to be able to add them to the backing part though. Also to avoid making assumptions, we'd need positional classes on the sidebar (if .left add the right border and vice-versa). Also we need padding working on the sidebar element to leave a gap before the first element to avoid the blue BG (when :selected) touching the eventual header bar border (example nautilus which does this right.
Regarding the separators we could deal with them with list element borders in the cases we need them (never IMHO), but that needs nth-child working, to do a polished job tho we'd need list elements to do unclipped drawind so a shadow on the selected element could cover them.
With all this stuff in place writing the style is trivial.
Comment 4 Matthias Clasen 2014-11-09 15:25:00 UTC
see bug 732050 for listbox separators