After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739758 - Losing file selection on saving
Losing file selection on saving
Status: RESOLVED FIXED
Product: easytag
Classification: Other
Component: general
2.3.x
Other Linux
: Normal normal
: 2.2
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
: 742021 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-11-07 04:18 UTC by J.B. Nicholson
Modified: 2015-06-28 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description J.B. Nicholson 2014-11-07 04:18:40 UTC
The file selection is lost on saving.

Steps to reproduce:
1. Select a directory with multiple audio files which don't trigger any kind of changes EasyTAG would automatically want to change in any way.

2. Select all of the audio files in that directory.

3. Click save.

You've specified no changes to be made to the files, so nothing needs saving. Yet now the file selection is now one of the audio files. I'm not sure exactly which file is picked, but I expected the file selection to remain unchanged.
Comment 1 David King 2014-11-07 09:00:42 UTC
This is a duplicate of an existing bug, where the save action is enabled even if there have been no changes. This has existed as far back as I can remember, and seems to be a hack to enable the use case of changing a text field in a file and then saving before moving to another file. The file is not marked as modified until moving to another file, but the save is permitted regardless.

*** This bug has been marked as a duplicate of bug 735366 ***
Comment 2 David King 2014-11-13 08:39:55 UTC
It seems that the selection also changes if one or more of the selected files has pending changes, so fixing the save bug will not solve this bug after all. There has also been another report on the mailing list: https://mail.gnome.org/archives/easytag-list/2014-November/msg00010.html
Comment 3 David King 2014-12-27 10:04:25 UTC
*** Bug 742021 has been marked as a duplicate of this bug. ***
Comment 4 David King 2015-06-28 20:33:44 UTC
Fixed in master in commit 891b557f77f4285282babb6540f8d150f6b25883.