After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739751 - Plug a placeholder leak in the box adaptor
Plug a placeholder leak in the box adaptor
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-06 23:06 UTC by Matthias Clasen
Modified: 2014-11-07 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Plug a placeholder leak in the box adaptor (1.12 KB, patch)
2014-11-06 23:06 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2014-11-06 23:06:04 UTC
gtk_widget_destroy() is not the right counterpart for
g_object_ref(), and it is useless anyway to do a ref-unref
pair around gtk_container_remove(), so just drop this.

This fix makes the placeholder instance count go down again
when shrinking the size of a box.
Comment 1 Matthias Clasen 2014-11-06 23:06:12 UTC
Created attachment 290124 [details] [review]
Plug a placeholder leak in the box adaptor
Comment 2 Tristan Van Berkom 2014-11-07 10:03:45 UTC
Comment on attachment 290124 [details] [review]
Plug a placeholder leak in the box adaptor

Thanks, please commit.
Comment 3 Matthias Clasen 2014-11-07 11:33:06 UTC
Attachment 290124 [details] pushed as 4d7c3d5 - Plug a placeholder leak in the box adaptor