After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739648 - pythonconsole: configure dialog uses deprecated stuff
pythonconsole: configure dialog uses deprecated stuff
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-04 22:17 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2019-03-23 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GdkRGBA instead of GdkColor (1.54 KB, patch)
2014-11-07 13:25 UTC, Sagar Ghuge 		needs-work Details | Review
Use GtkGrid directly instead of GtkDialog (9.69 KB, patch)
2014-11-07 13:29 UTC, Sagar Ghuge 		none Details | Review
Use GdkRGBA instead of GdkColor (1.13 KB, patch)
2014-11-10 05:43 UTC, Sagar Ghuge 		committed Details | Review
Use GtkGrid directly instead of GtkDialog (10.39 KB, patch)
2014-11-10 05:56 UTC, Sagar Ghuge 		committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2014-11-04 22:17:45 UTC 
it is still using gdk color while it should use gdk rgba also the ui file uses a dialog while now it is possible to get an object directly without the need for a window parent
Comment 1 Sagar Ghuge 2014-11-07 13:25:33 UTC 
Created attachment 290161 [details] [review]
Use GdkRGBA instead of GdkColor
Comment 2 Sagar Ghuge 2014-11-07 13:29:11 UTC 
Created attachment 290162 [details] [review]
Use GtkGrid directly instead of GtkDialog
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-11-07 13:35:53 UTC 
Review of attachment 290161 [details] [review]:

See the comment

::: plugins/pythonconsole/pythonconsole/config.py
@@ +44,2 @@
     def configure_widget(self):
+        self._ui.add_from_file(self._ui_path)

this part should go in the other patch
Comment 4 Sagar Ghuge 2014-11-10 05:43:07 UTC 
Created attachment 290301 [details] [review]
Use GdkRGBA instead of GdkColor
Comment 5 Sagar Ghuge 2014-11-10 05:56:26 UTC 
Created attachment 290302 [details] [review]
Use GtkGrid directly instead of GtkDialog
Comment 6 Ignacio Casal Quinteiro (nacho) 2014-11-20 07:16:41 UTC 
Review of attachment 290301 [details] [review]:

Looks good.
Comment 7 Ignacio Casal Quinteiro (nacho) 2014-11-20 07:17:21 UTC 
Review of attachment 290302 [details] [review]:

Looks good.
Comment 8 Sébastien Wilmet 2014-11-29 16:33:12 UTC 
Sagar, don't forget to close a bug once the commits are pushed (as it is the case here). And mark the commits as committed.