GNOME Bugzilla – Bug 739647
Custom shortcut dialog should require name and command
Last modified: 2015-02-10 12:52:07 UTC
The custom shortcut dialog in gnome-control-center allows that the name field and the command field is empty. This can produce confusing results.
Steps to reproduce:
1. Go to the Keyboard panel.
2. Select the Shortcuts tab.
3. Press the plus (+) button to add a new custom shortcut.
4. Press the Add button in the Custom Shortcuts dialog without entering anything in the name field or in the command field.
The Add button is disabled until both the name and the command is filled in.
The dialog disappears and no shortcut is created. Also, if an existing shortcut is edited and the command field is empty then the shortcut is removed.
It should only be possible to add a shortcut or edit an existing shortcut if both the name field and the command field is filled in. Especially, the shortcut should not be removed if the command field is empty; there is a button specifically for removing shortcuts.
Created attachment 289994 [details] [review]
keyboard: custom shortcut should require name and command
This patch disables the Add button, it is only enabled when the name and command is non-empty.
Review of attachment 289994 [details] [review]:
Attachment 289994 [details] pushed as fe9fe99 - keyboard: custom shortcut should require name and command