GNOME Bugzilla – Bug 739641
Emit animation-completed::zoom?
Last modified: 2014-11-10 06:11:58 UTC
Would it make sense to emit this signal on zoom animation complete? The documentation states: "This is a detailed signal. For example, if you want to be signaled only for go-to animation, you should connect to "animation-completed::go-to"." But it is only emitted for animation-completed::go-to as far as I can see. Having would give application developers more fine grained control of when to do stuff. But maybe it will break stuff that assumes that animation-completed is only for go-to?
Created attachment 289990 [details] [review] ChamplainView: Emit animation-completed::zoom
And maybe ensure_visible that potentially does both zoom and go-to should emit just animation-completed when both are done?
(In reply to comment #2) > And maybe ensure_visible that potentially does both zoom and go-to should emit > just animation-completed when both are done? Na, I guess that doesn't work.
Review of attachment 289990 [details] [review]: Looks good.
Makes sense - when I added the zoom animation, I forgot we have some signal for animation completion and that I should add a signal for it. I've just pushed the patch to master, thanks. Just wondering - is that something you just noticed or is there some real practical need for this signal?
(In reply to comment #5) > Makes sense - when I added the zoom animation, I forgot we have some signal for > animation completion and that I should add a signal for it. I've just pushed > the patch to master, thanks. > > Just wondering - is that something you just noticed or is there some real > practical need for this signal? There have been sometimes during Maps dev that I felt like I wanted one. And I will add this to a few places in Maps.