After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739594 - Support refreshing credentials from a smartcard
Support refreshing credentials from a smartcard
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Kerberos
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-03 21:24 UTC by Ray Strode [halfline]
Modified: 2015-05-22 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ticketing: add new details property (2.37 KB, patch)
2014-11-03 21:24 UTC, Ray Strode [halfline]
committed Details | Review
kerberos: support refreshing smartcard authenticated kerberos tickets (84.15 KB, patch)
2014-11-03 21:24 UTC, Ray Strode [halfline]
committed Details | Review
ticketing: add new details property (2.60 KB, patch)
2014-11-05 19:18 UTC, Ray Strode [halfline]
committed Details | Review
dbus: Add Details to org.gnome.OnlineAccounts.Ticketing (1.29 KB, patch)
2015-05-04 17:39 UTC, Debarshi Ray
committed Details | Review
kerberos: Support refreshing smartcard authenticated kerberos tickets (23.32 KB, patch)
2015-05-04 17:40 UTC, Debarshi Ray
committed Details | Review

Description Ray Strode [halfline] 2014-11-03 21:24:39 UTC
These two commits add support for refreshing kerberos credentials backed by a smartcard.

Note they only add support for refreshing existing credentials from smartcard login.
It doesn't currently add UI to control-center for electing to use a smartcard at
account creation time. That's something we should definitely add down the line.

This bug depends on the fixes in bug 739590 and bug 739593
Comment 1 Ray Strode [halfline] 2014-11-03 21:24:41 UTC
Created attachment 289948 [details] [review]
ticketing: add new details property

This commit adds a new "details" variant for attaching metadata
about tickets getting requested via the ticketing interface.

This will give the kerberos account provider a place to tuck away
kerberos-specific preauthentication configuration for the tickets
associated with smartcard backed kerberos accounts.
Comment 2 Ray Strode [halfline] 2014-11-03 21:24:44 UTC
Created attachment 289949 [details] [review]
kerberos: support refreshing smartcard authenticated kerberos tickets

Right now gnome-online-accounts doesn't manager smartcard based
kerberos credentials very well.  The sign-in button just fails.

This commit adds support for tickets granted through smartcards.

Note, at the moment we don't provide a way to add new smartcard
based accounts, merely, manage existing ones that are added implicitly
by logging in with a smartcard, or by explicit kinit.
Comment 3 Debarshi Ray 2014-11-04 15:30:56 UTC
Review of attachment 289948 [details] [review]:

::: data/dbus-interfaces.xml
@@ +738,3 @@
   -->
   <interface name="org.gnome.OnlineAccounts.Ticketing">
+    <property name="details" type="a{ss}" access="read"/>

Needs a documentation string and '@since: 3.16'.
Comment 4 Ray Strode [halfline] 2014-11-05 19:18:23 UTC
Created attachment 290046 [details] [review]
ticketing: add new details property

This commit adds a new "details" variant for attaching metadata
about tickets getting requested via the ticketing interface.

This will give the kerberos account provider a place to tuck away
kerberos-specific preauthentication configuration for the tickets
associated with smartcard backed kerberos accounts.
Comment 5 Debarshi Ray 2015-05-04 17:39:49 UTC
Created attachment 302889 [details] [review]
dbus: Add Details to org.gnome.OnlineAccounts.Ticketing

Updated the version in the since tag, and capitalized the 'D' in 'Details' for consistency.
Comment 6 Debarshi Ray 2015-05-04 17:40:28 UTC
Created attachment 302890 [details] [review]
kerberos: Support refreshing smartcard authenticated kerberos tickets
Comment 7 Debarshi Ray 2015-05-04 17:41:37 UTC
We have been shipping these in RHEL for quite some time now. Sorry for having let these slip through the cracks.
Comment 8 Debarshi Ray 2015-05-22 13:24:36 UTC
The order in which these patches were generated (with respect to bug 739593), was different from the RHEL patches. I rebased these against master in the same order as RHEL since that is what we have been actually shipping so far.