After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739580 - basesink: Answer the query position when receiving it from upstream
basesink: Answer the query position when receiving it from upstream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-03 17:34 UTC by Thibault Saunier
Modified: 2014-11-08 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basesink: Answer the query position when receiving it from upstream (1.08 KB, patch)
2014-11-03 17:34 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2014-11-03 17:34:28 UTC 
Currently we are just returning FALSE, but we do have the information
we should just answer the query the same way as when answering through
the GstElement.query vmethod default implementation.
Comment 1 Thibault Saunier 2014-11-03 17:34:31 UTC 
Created attachment 289921 [details] [review]
basesink: Answer the query position when receiving it from upstream
Comment 2 Sebastian Dröge (slomo) 2014-11-04 09:54:30 UTC 
You mean downstream btw, there is no upstream of basesink ;)
Comment 3 Sebastian Dröge (slomo) 2014-11-04 10:03:06 UTC 
Ignore that comment :) We're talking about basesink, not basesrc here.
Comment 4 Thibault Saunier 2014-11-04 10:46:26 UTC 
(In reply to comment #3)
> Ignore that comment :) We're talking about basesink, not basesrc here.

Yeah, I felt I had not understood anything about GStreamer reading your comment :P
Comment 5 Thibault Saunier 2014-11-04 14:48:02 UTC 
Attachment 289921 [details] pushed as 56606c5 - basesink: Answer the query position when receiving it from upstream