GNOME Bugzilla – Bug 739567
Comment in sol.c is needlessly offensive
Last modified: 2015-01-09 11:41:28 UTC
sol.c contains a comment about some of the choices made for ubuntu's default desktop as being "crap". I think this kind of comment reflects badly on the GNOME project and it is better to avoid it. Also, setting those environment variables doesn't make a lot of sense to me. Ubuntu patches them out anyway, which makes running aisleriot from git different from running the packaged version on ubuntu. Most GNOME projects support running on platforms with slightly different UI choices just fine. In fact, a similar thing was removed from gnome-terminal recently. I attached a patch which removes the whole code block.
Created attachment 289897 [details] [review] Don't set ubuntu-specific environment variables
Comment on attachment 289897 [details] [review] Don't set ubuntu-specific environment variables I'd accept a patch that does this similarly to gnome-terminal commit 04d58702ff269343a3b8b992ff545b9bb3a76ae9. Just removing this isn't right, since building from upstream git should give you upstream behaviour.
Building from upstream git will give you upstream behavior, as long as you are building the things that Ubuntu has modified. It's not clear to me why building Aisleriot from git would change the menubar or scrollbar behavior, since these things apply to the entire desktop. And it's not clear to me who this is for. Someone who doesn't like these behaviors would disable them or use a different desktop. Developers working on Aisleriot don't benefit from the inconsistency, if anything they're hampered by having to deal with a different UI. Nor will the difference in Aisleriot's behavior help to convince anyone that Unity's UI choices were poor. So, it feels to me like the code is only there to spite Canonical, which I don't like to see in a GNOME project.
(In reply to comment #2) > (From update of attachment 289897 [details] [review]) > I'd accept a patch that does this similarly to gnome-terminal commit > 04d58702ff269343a3b8b992ff545b9bb3a76ae9. Just removing this isn't right, since > building from upstream git should give you upstream behaviour. I'd rather patch it out in ubuntu's package than seeing this kind of unnecessary complexity being added. "Upstream behavior" for the majority of GNOME applications seems to be to adapt to the platform when possible (and reasonable). This is only changing some very specific behavior on a single platform. Also, changing behavior based on where the source is from is just confusing.
You appear to think about those ubuntu modules as just harmless add-ons that change appearance a bit. I however think about them as sources of bugs (there actually have been bugs in aisleriot and other modules caused by those modules), so I want the pristine configuration from a git build to have the upstream behaviour, unmodified by any such modules. Since there seems to be no interest in a gnome-terminal like solution (comment 4), closing.
(In reply to comment #5) > You appear to think about those ubuntu modules as just harmless add-ons that > change appearance a bit. I however think about them as sources of bugs (there > actually have been bugs in aisleriot and other modules caused by those > modules), so I want the pristine configuration from a git build to have the > upstream behaviour, unmodified by any such modules. There have been bugs. Let's make it hard for people to find and fix them! > Since there seems to be no interest in a gnome-terminal like solution (comment > 4), closing. This bug is mainly about an offensive comment, which is still there. Reopening.