After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739478 - Add support for digital storage units conversion
Add support for digital storage units conversion
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-01 05:30 UTC by Popo
Modified: 2014-12-27 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add support for digital storage units conversion (7.26 KB, patch)
2014-11-01 05:34 UTC, Popo 		committed Details | Review

Description Popo 2014-11-01 05:30:30 UTC 
Hi! I created a patch for this. It covers the commonly used digital storage units in both decimal and binary types - from bit, byte and {kilo,mega,giga,tera,peta,kibi,mebi,gibi,tebi,pebi}{bit,byte}

Let me know if it's good enough for inclusion in the gnome-cacl or if there's something I need to fix for it to be accepted
Comment 1 Popo 2014-11-01 05:34:26 UTC 
Created attachment 289766 [details] [review]
add support for digital storage units conversion
Comment 2 PioneerAxon 2014-12-27 17:14:58 UTC 
Review of attachment 289766 [details] [review]:

Looks good.

I've modified some, and added new conversions+tests in final patch.

Thanks.. :)
Comment 3 PioneerAxon 2014-12-27 17:16:31 UTC 
Thanks for the feature request, and the diff. :)

Reference commit : https://git.gnome.org/browse/gnome-calculator/commit/?id=919c163a814279cfbfdf455fe1d42d564b0a654d