Created attachment 289743 [details] [review]
One example

(In reply to comment #0)
> USE_GNOME2_MACROS=1 in autogen.sh seems redundant, especially on reading the
> following discussion at
> https://mail.gnome.org/archives/games-list/2010-November/msg00007.html

Yes I agree, and thanks to this bug I realized that the same happens with atk.

As a reference, I used gtk's autogen.sh, and removed the gtkdoc check (as jaw doesn't use it). You could use as a reference (or not). In general this is really similar to at-spi one, but with some extra checks and informative error messages.

Review of attachment 289743 [details] [review]:

This seems like a good way to go for an update to the script. It builds ok and seems to draw attention to some warnings which seems likely to be of use.

One small thing I am not totally sure about is the rationale for removing REQUIRED_AUTOMAKE_VERSION altogether? Can you clarify why you chose to do that?

Review of attachment 289743 [details] [review]:

I am committing this myself since it is the weekend and I have some time to do some follow up work before Monday.[1] Besides that I think it is safe to say we can trust it to be good. :-)

Thanks for your work.

[1] https://git.gnome.org/browse/java-atk-wrapper/commit/?id=63ec9208d5d004244cc270bf1510ff5273976a03

::: autogen.sh
@@ -9,2 @@
-PKG_NAME=java-atk-wrapper
-USE_GNOME2_MACROS=1 . gnome-autogen.sh

Just thinking I should comment on this 

. gnome-autogen.sh
	 
so there is a reference to it in the bug. I noticed running this on osx raised an error so I think it is right that you chose to remove it. However, I am a bit unsure what it would have been for once. Any ideas?

Review of attachment 289743 [details] [review]:

I am committing this myself since it is the weekend and I have some time to do some follow up work before Monday.[1] Besides that I think it is safe to say we can trust it to be good. :-)

Thanks for your work.

[1] https://git.gnome.org/browse/java-atk-wrapper/commit/?id=63ec9208d5d004244cc270bf1510ff5273976a03

::: autogen.sh
@@ -9,2 @@
-PKG_NAME=java-atk-wrapper
-USE_GNOME2_MACROS=1 . gnome-autogen.sh

Just thinking I should comment on this 

. gnome-autogen.sh
	 
so there is a reference to it in the bug. I noticed running this on osx raised an error so I think it is right that you chose to remove it. However, I am a bit unsure what it would have been for once. Any ideas?

(In reply to comment #2)
> Review of attachment 289743 [details] [review]:

> One small thing I am not totally sure about is the rationale for removing
> REQUIRED_AUTOMAKE_VERSION altogether? Can you clarify why you chose to do that?

As I said that autogen.sh is basically a C&P of gtk's autogen, that doesn't include that check. If you find it necessary you just can add it.

(In reply to comment #3)

> . gnome-autogen.sh
> 
> so there is a reference to it in the bug. I noticed running this on osx raised
> an error so I think it is right that you chose to remove it. However, I am a
> bit unsure what it would have been for once. Any ideas?

This new autogen already calls autoreconf and others to create the configure, so doing what is currently doing and additionally calling gnome-autogen.sh is redundant. So the options is or using a manually-written autogen.sh or calling gnome-autogen.sh. You can see what gnome-autogen.sh does here:

https://git.gnome.org/browse/gnome-common/tree/macros2/gnome-autogen.sh

[Moving at-spi/java-atk-wrapper bugs to separate product. See bug 740075]