After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739421 - editor: Don't use deprecated margin-right property
editor: Don't use deprecated margin-right property
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-30 18:37 UTC by Marcus Karlsson
Modified: 2015-02-22 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dconf-editor: Use margin-end instead of margin-right (1.16 KB, patch)
2014-10-30 18:41 UTC, Marcus Karlsson 		committed Details | Review

Description Marcus Karlsson 2014-10-30 18:37:05 UTC 
Dconf-editor uses the deprecated GtkWidget property "margin-right." This yields the following message on the console when launching the application:

(dconf-editor:24001): GLib-GObject-WARNING **: The property GtkWidget:margin-right is deprecated and shouldn't be used anymore. It will be removed in a future version.

It is used in the "key_info_grid" grid in the file dconf-editor.ui. It should use the "margin-end" property instead, which unlike "margin-right" handles both left-to-right and right-to-left text directions.
Comment 1 Marcus Karlsson 2014-10-30 18:41:17 UTC 
Created attachment 289692 [details] [review]
dconf-editor: Use margin-end instead of margin-right

This patch makes dconf-editor use the "margin-right" property.
Comment 2 Robert Ancell 2014-10-30 20:29:28 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Robert Ancell 2014-10-30 20:29:58 UTC 
Review of attachment 289692 [details] [review]:

Looks good, thanks Marcus!
Comment 4 André Klapper 2015-02-22 12:23:49 UTC 
[moving dconf>editor tickets to dconf-editor product. See bug 744791]