GNOME Bugzilla – Bug 739398
Move mouse plugin features to mutter
Last modified: 2015-04-08 15:15:14 UTC
On bug #739397 I've attached some patches to make mutter itself take care of translating input device settings to windowing specific terms. This implies that, more or less coordinately, the g-s-d mouse plugin should stop attempting to do the same. The features I'm shuffling so far are: - mouse/touchpad handedness - mouse/touchpad acceleration - touchpad natural scroll - touchpad tap-enabled - touchpad enabling/disabling Other mouse plugin features (locate pointer, syndaemon, mousetweaks, touchpad enabling when it's the single pointer device) stay so far, but some of these should be eventually moved or reconsidered. NB: The patches here do nothing yet about moving the gsettings schemas around. If mutter/g-s-d/g-c-c start reading the same settings, it is a good indication that they should go somewhere else, probably gsettings-desktop-schemas, the "org.gnome.settings-daemon" prefix starts losing sense though...
Created attachment 289653 [details] [review] mouse: Remove management of tap-to-click setting This is now managed by mutter itself, along with other input device settings.
Created attachment 289654 [details] [review] mouse: Remove management of mouse/touchpad left-handed mode This is now managed by mutter itself, along with other input device settings.
Created attachment 289655 [details] [review] mouse: Remove natural-scrolling setting management This is now managed by mutter, along with other input settings.
Created attachment 289656 [details] [review] mouse: Remove management of touchpad-enabled The mouse plugin still takes care of re-enabling the setting if no more pointing devices are available, but the actual enabling/disabling of devices is now purely handled by mutter.
Created attachment 289657 [details] [review] mouse: Remove management of motion-acceleration/threshold This is now handled by mutter itself, along with other input settings.
A couple of things: - mutter doesn't launch the "custom command" associated with the device. This is probably the right thing to do for Wayland, but not for X11 (at least not in the short term). - the GSettings do indeed need to move to gsettings-desktop-schemas, that'd be a prerequisite of this bug. There are a number of other settings that are missing. Those require libinput changes: https://bugs.freedesktop.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=libinput&email1=hadess&emailassigned_to1=1&emailcc1=1&emailreporter1=1&emailtype1=substring&list_id=486825&product=Wayland&query_format=advanced
(In reply to comment #6) > A couple of things: > - mutter doesn't launch the "custom command" associated with the device. This > is probably the right thing to do for Wayland, but not for X11 (at least not in > the short term). Right, that indeed was one of the parts I was most hesitant of on wayland. > - the GSettings do indeed need to move to gsettings-desktop-schemas, that'd be > a prerequisite of this bug. I've filed bug #739411 (and bug #739412 on g-s-d) about this. > > There are a number of other settings that are missing. Those require libinput > changes: > https://bugs.freedesktop.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=libinput&email1=hadess&emailassigned_to1=1&emailcc1=1&emailreporter1=1&emailtype1=substring&list_id=486825&product=Wayland&query_format=advanced Indeed, those eventually need to be handled too. These commits are admittedly just a start, ideally we wouldn't be prolonging too much with the switch, but some parts are more ready than others.
Closing, as the mouse plugin handles only evdev/synaptics devices, and mutter takes care of xf86-libinput/wayland settings. evdev/synpatics support will be removed in bug 747513 for 3.18.