After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739357 - drop custom implementation of Switch in js/ui/popupMenu.js in favor of GtkSwitch
drop custom implementation of Switch in js/ui/popupMenu.js in favor of GtkSwitch
Status: RESOLVED DUPLICATE of bug 639794
Product: gnome-shell
Classification: Core
Component: general
3.14.x
Other All
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-29 14:34 UTC by Stanislav Brabec
Modified: 2014-11-07 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stanislav Brabec 2014-10-29 14:34:48 UTC
js/ui/popupMenu.js contains a custom implementation of Switch.

The widget is visually nearly equal to the new GTK+3 GtkSwitch widget and IMHO it should be replaced by it.

These implementation diverged in translations, which causes inconsistencies in gnome-shell look. GTK+3 GtkSwitch widget allows to use arbitrary short text or ○/❙. gnome-shell Switch allows only ON/OFF and ○/❙.

For example:

German:
gnome-shell: ON/OFF
elsewhere: AN/AUS

Danish:
gnome-shell: ❙/○
elsewhere: TIL/FRA

Japanese:
gnome-shell: ON/OFF
elsewhere: オン/オフ

Simplified Chinese:
gnome-shell: ON/OFF
elsewhere: 开启/关闭
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-10-29 15:04:08 UTC
Unfortunately you cannot use GTK+ widgets inside GNOME Shell due to the way it, and GTK+, are both architected, though that's something I'd love to change. Feel free to improve the implementation of GNOME Shell's widget.
Comment 2 Bastien Nocera 2014-11-07 18:17:50 UTC
Bug 639794 is specifically about reusing the translations from GTK+ in gnome-shell, so marking as a duplicate.

*** This bug has been marked as a duplicate of bug 639794 ***