After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739353 - Unable to build when GDK_WINDOWING_X11 not defined
Unable to build when GDK_WINDOWING_X11 not defined
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
3.14.x
Other Mac OS
: Normal normal
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
Depends on:
Blocks: wayland
 
 
Reported: 2014-10-29 12:56 UTC by Jason Penney
Modified: 2015-04-21 09:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
utils.h patch (500 bytes, patch)
2014-10-30 10:24 UTC, Jason Penney 		none Details | Review

Description Jason Penney 2014-10-29 12:56:44 UTC 
When trying to build zenity against gtk3 (3.14.4) built against quartz, rather than X11, src/util.h won't compile due to the following:

void            zenity_util_show_dialog                   (GtkWidget      *widget, Window parent);

"Window" is not defined unless GDK_WINDOWING_X11 is defined.  

I tried changing:

#ifdef GDK_WINDOWING_X11
#include <gdk/gdkx.h>
#endif

to:

#ifdef GDK_WINDOWING_X11
#include <gdk/gdkx.h>
#else
typedef gint Window;
#endif


This builds and is working for me, but there is probably a more correct solution.
Comment 1 Arx Cruz 2014-10-29 13:41:20 UTC 
I'm not a GDK expert, I think it's okay, do you want to test more extensively, and then submit a patch?
Comment 2 Jason Penney 2014-10-30 10:24:42 UTC 
Created attachment 289638 [details] [review]
utils.h patch

Here's the patch.  Everything seems to be working with my gtk-quartz build with this, although it does generate the following output:

Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
Comment 3 Arx Cruz 2015-04-21 09:01:56 UTC 
Fixed on master.
Thanks for the patch