After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739344 - rtpjitterbuffer: ensure rtx_retry_period >= 0
rtpjitterbuffer: ensure rtx_retry_period >= 0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.1
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-29 10:28 UTC by Miguel París Díaz
Modified: 2014-11-22 14:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.11 KB, patch)
2014-10-29 10:28 UTC, Miguel París Díaz
committed Details | Review

Description Miguel París Díaz 2014-10-29 10:28:18 UTC
Created attachment 289572 [details] [review]
Patch

When rtx_retry_timeout is greater than the jitterbuffer latency, rtx_retry_period is less than 0 but it is an unsigned value, so we get a very very big timer and the jitterbuffer retains the packets until it is reset.
Comment 1 Tim-Philipp Müller 2014-11-22 14:51:30 UTC
Thanks for the patch, pushed:

 commit 6daa57868f01da46aa2c6cfc0a4dc8344312e4c1
 Author: Miguel París Díaz <mparisdiaz@gmail.com>
 Date:   Mon Oct 20 13:00:37 2014 +0200

    rtpjitterbuffer: ensure rtx_retry_period >= 0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739344